koji

#4397 Clean up cli for comps management
Merged by mikem. Opened by mikem.
mikem/koji comps-cli-updates  into  master

Download 4397.patch

Each of the three major data portions for comps (groups, packages, group reqs) has Add, Remove, Block, and Unblock calls in the api, but in the cli things are less consistent

  • we have a remove-group command, but no remove commands for packages or reqs
  • we have block-group, but not unblock-group

Furthermore, some of the cli sanity checks are unhelpful or just wrong

Fixes https://pagure.io/koji/issue/3199
Fixes https://pagure.io/koji/issue/4393

~~This is currently a draft. Unit tests still need updating, and I need to manually test it more.~~
Edited by mikem

Started from a rebase of #3201

For background, see #3199 and #4393

2 new commits added

  • docs updates
  • unit tests

@julian8628 @jcupova

1 new commit added

  • flake8

Only a trivial fix needed for the new tests: 

-import mock
+try:
+    from unittest import mock
+except ImportError:
+    import mock

because mock isn't installed in py3 test env. Otherwise it's good to me
Edited by julian8628

1 new commit added

  • update mock imports

Metadata Update from @mikem:
- Pull-request tagged with: testing-custom

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

rebased onto f2b13a9ae219f14c3400f38587416fa9d1255b2e

Commit 311dfde7 fixes this pull-request

Pull-Request has been merged by mikem
Metadata
None

testing-custom testing-done

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.