koji

#4413 Fix race handling in get_next_build
Merged by mikem. Opened by mikem.
mikem/koji release-race-again  into  master

Download 4413.patch

The code from #3103 attempts to handle race conditions, but fails to recover because the transaction itself has failed. Rolling back to a savepoint allows us to keep going.

Fixes https://pagure.io/koji/issue/4414

~~I am so far unable to make this race happen locally. It was observed on a live system.~~
Edited by mikem

1 new commit added

  • fix a separate race case

Replicating a race with fakehub. Salt to taste

# set up two fake tasks and have a builder user open then
$ ./devtools/fakehub -u mikem makeTask sleep '[120]'
$ ./devtools/fakehub -u mikem makeTask sleep '[120]'
$ ./devtools/fakehub -u builder-02 -x host.openTask 14475
$ ./devtools/fakehub -u builder-02 -x host.openTask 14476
# (the following in parallel should hit the race)
$ while ./devtools/fakehub -u builder-02 -x host.initImageBuild 14475 "{'name':'foo', 'version':'100', 'epoch':None}"; do echo; done
$ while ./devtools/fakehub -u builder-02 -x host.initImageBuild 14476 "{'name':'foo', 'version':'100', 'epoch':None}"; do echo; done
Edited by mikem

@julian8628

:thumbsup:

Metadata Update from @mikem:
- Pull-request tagged with: testing-custom

Metadata Update from @mikem:
- Pull-request tagged with: bug

Metadata Update from @mikem:
- Pull-request untagged with: bug

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

rebased onto 134ec54d56a1e74c3f8cf9a6322d76355e08650c

Commit adbe584a fixes this pull-request

Pull-Request has been merged by mikem
Metadata
None

testing-custom testing-done

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.