koji

#4480 Add weblink to NVR build for draft builds
Merged by mikem. Opened by avsingh.
avsingh/koji 4438_weblink_draftbuild  into  master

Download 4480.patch

This PR adds a new weblink for draft builds when another build has claimed the NVR.

Fixes https://pagure.io/koji/issue/4438

Looks good overall! Just a couple minor things

In the exception handler, you set promoted_build = None, but this is already the value that was set earlier.

The code should probably verify that the found build is indeed a non-draft one. The release value should ensure that, but better to check explicitly.

The heading in the template isn't very clear. I'd recommend using "Draft superseded by:" or similar.

1 new commit added

  • Fixes: https://pagure.io/koji/issue/4438

1 new commit added

  • use non breaking spaces

Looks good overall! Just a couple minor things

In the exception handler, you set promoted_build = None, but this is already the value that was set earlier.

The code should probably verify that the found build is indeed a non-draft one. The release value should ensure that, but better to check explicitly.

The heading in the template isn't very clear. I'd recommend using "Draft superseded by:" or similar.

Updated code to explicitly check draft builds and then only set promoted_build to non-null.
Also updated the row header to Draft superseded by: without breaking spaces.

:thumbsup:

Metadata Update from @mikem:
- Pull-request tagged with: testing-basic

Metadata Update from @mfilip:
- Pull-request tagged with: testing-done

Commit 4a974634 fixes this pull-request

Pull-Request has been merged by mikem
Metadata
None

testing-basic testing-done

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.