koji

#451 Python3 changes
Closed by tkopecek. Opened by tkopecek.
tkopecek/koji python3  into  master

Download 451.patch

I've made few more changes which shouldn't break too much, but improve python3 test coverage.

I've not touched unicode/str/bytes handling yet, as it brings few problems and fixed module loading in tests as it was not working "python3 way", but only using deprecated imp module.

:thumbsup:

Putting this on hold until after 1.13 gets out. For now, we're sticking with just cli/lib for py3 support

rebased

@tkopecek @mikem Now that 1.13 is out, could we have full py3 for 1.14 (which I think this PR is supposed to accomplish)?

@ngompa Full support (hub, web, builder) is not feasible in short time. There are some important dependencies which will probably never ported to python3. What I'm trying to do here is to convert as most as possible.

Anyway, I'll rebase this one, so we can proceed.

rebased

rebased onto 664f3b8df9ec26701cea2b6923430750e8c1ecfa

rebased onto 03ba74a628f10bdd21bb064c396179ec8b6595e1

Hmm, I broke this branch. Fixing...

rebased onto 040b4b62e8aea84a1915d5e7d7253345af7db608

@mikem https://pagure.io/fork/tkopecek/koji/c/6beac30dff9a7e6668e7fa912941e26c254e32d5 Why are here fixEncodings? It breaks a lot under python3 (fixEncoding returns bytes instead of strings) and I don't understand what can go wrong there. It should be converted before insert to db and also on filesystem it should be ok. Is there something I'm missing?

Pull-Request has been closed by tkopecek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.