koji

#4515 download-build: exit non-zero if all downloads skipped
Opened by adamwill. Modified
adamwill/koji download-build-nothing-error  into  master

Download 4515.patch

In https://pagure.io/fedora-ci/general/issue/536 we noticed that
download-build does not exit 0 even if it winds up downloading
nothing at all. This can happen if all packages are skipped
because they're for the wrong arch, or they're debuginfo and
you didn't pass the argument to download debuginfo packages, or
they're not signed and you passed --key and didn't pass
--fallback-unsigned.

It seems more useful to error in this case, since this is
probably not what the caller expected.

Signed-off-by: Adam Williamson awilliam@redhat.com

I'm not totally sure about this, it is a behavior change. It's possible there are folks out there scripting nonsensical koji download-build commands willy-nilly and expecting them to just quietly do nothing if they don't make sense. But I figured I'd suggest it at least. See https://pagure.io/fedora-ci/general/issue/536#comment-996529 for the background. Getting a release done with the --fallback-unsigned feature in it and then getting a Bodhi release done which uses it would mitigate this substantially, I think, but it'd still be technically possible for it to happen I guess.
Edited by adamwill
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.