koji

#4558 better handling of volume topdir problems
Opened by mikem. Modified
mikem/koji volume-toplink-fix  into  master

Download 4558.patch

Fixes: #4555

  • unify toplink check logic into check_volume_toplink()
  • add a nonstrict check in _set_build_volume
  • strict check for toplink at beginning of promotion
  • but do not fail promotion mid-process if backlink creation fails later
  • bunches of new unit tests

So, if a volume toplink is missing/invalid:

  • add_volume will log and create it
  • promoting a build on that volume will fail early, with no changes
  • volume moves to said volume will log an error, but neither fail nor create the toplink

@tkopecek @julian8628

2 new commits added

  • catch samefile errors, more tests
  • just create the toplink when we need it

Metadata Update from @tkopecek:
- Pull-request tagged with: testing-basic, testing-ready
Metadata
None

testing-basic testing-ready

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.