#49 Run plugin callbacks when image builds finish.
Closed by mikem. Opened by ralph.
ralph/koji master  into  master

Download 49.patch
no initial comment

We hit this in prod in Fedora.

  • When image builds fail, the builder calls failBuild on the hub and it correctly calls run_callbacks on the plugins for both pre/postImport and pre/postBuildStateChange.
  • When image builds succeed, the builder calls completeImageBuild on the hub and while it correctly calls run_callbacks for pre/postImport, it does not call it for pre/postBuildStateChange.

The symptom that we see is that we get fedmsg messages for failed image builds, but we get radio silence for successful image builds.

Looks good, rebasing and manually merging

Pull-Request has been closed by mikem

st_complete is undefined here. causing all image builds to fail

Metadata