#506 Track artifacts coming from koji itself
Merged by mikem. Opened by tkopecek.
tkopecek/koji mw-tracking  into  master

Download 506.patch
no initial comment

I'm not convinced that a separate toplevel "kojifile" type in the cg schema metadata is the right path, but otoh the "file" type is kind of a mess, so maybe it is best to distinguish them strongly.

Since we are adding a new toplevel component type, that is by definition intended to match a koji file, then we should actually raise errors if there are problems. E.g.

  • if there is no match
  • if the archive specified by archive_id does not match the nvr+filename given
  • if the checksum does not match
  • if the size does not match

Given that we are overspecifying the archive, I wonder how much of this data we should strictly require. Technically, archive_id is sufficient. It is nice to have the extra data for sanity checks, but I'm not sure if we need to require quite all the fields that are listed in the doc.

How about this?
https://github.com/mikem23/koji-playground/commits/mw-tracking

:thumbsup:

ok, I'll merge that version

Commit 8ac81675 fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

Metadata