#51 structural help, categorize commands into groups
Closed by mikem. Opened by xning.
xning/koji master  into  master

Download 51.patch
no initial comment

This looks good. Some questions/comments:

  • download is misspelled in the help ("downlaod")
  • does this work on rhel5? It doesn't look like the optparse in 2.4 supports epilogs. We are not quite ready to drop rhel5 support in koji, so this needs to be addressed.
  • I'm not sure about having each category be an individual option to the help command. I realize this is what we were doing when it was just --admin, but with multiple defined categories it seems more natural to just make it an argument instead (of course we'd want to preserve --admin for backwards compatibility).

Some possibly misfiled commands:

  • call is probably more miscellaneous than admin
  • tag-build is listed in misc and {move,untag}-build in build. Neither seems correct. Do we need another category?
  • mock-config isn't really a download command. perhaps info or misc
  • spin-appliance and spin-livecd are build commands
  • download-task should be in the download category
  • image-build-indirection is a build command

Hi Michael,

OK. I will recreate the pull request. Remove the epilog, and use a way as f=
ollow codes show

parser.dict['origin_format_help'] =3D parser.format_help
parser.dict['format_help'] =3D lambda formatter=3DNone: parser.origin_f=
ormat_help(formatter) + "%s\n" % get_epilog_str()=20

----- =E5=8E=9F=E5=A7=8B=E9=82=AE=E4=BB=B6 -----
=E5=8F=91=E4=BB=B6=E4=BA=BA: pagure@pagure.io
=E6=94=B6=E4=BB=B6=E4=BA=BA: xning@redhat.com
=E5=8F=91=E9=80=81=E6=97=B6=E9=97=B4: =E6=98=9F=E6=9C=9F=E4=BA=8C, 2016=E5=
=B9=B4 4 =E6=9C=88 05=E6=97=A5 =E4=B8=8A=E5=8D=88 4:16:28
=E4=B8=BB=E9=A2=98: [koji] Update to koji pull-Request #51 structural help= , categorize commands into groups

mikem commented on the pull-request: structural help, categorize commands = into groups that you are following:
``
This looks good. Some questions/comments:

  • download is misspelled in the help ("downlaod")
  • does this work on rhel5? It doesn't look like the optparse in 2.4 support=
    s epilogs. We are not quite ready to drop rhel5 support in koji, so this ne=
    eds to be addressed.
  • I'm not sure about having each category be an individual option to the he=
    lp command. I realize this is what we were doing when it was just --admin, =
    but with multiple defined categories it seems more natural to just make it =
    an argument instead (of course we'd want to preserve --admin for backwards =
    compatibility).

``

To reply, visit the link belowor just reply to this email
https://pagure.io/koji/pull-request/51

Pull-Request has been rebased

This looks good. Some questions/comments:

download is misspelled in the help ("downlaod")
does this work on rhel5? It doesn't look like the optparse in 2.4 supports epilogs. We are not quite ready to drop rhel5 support in koji, so this needs to be addressed.
I'm not sure about having each category be an individual option to the help command. I realize this is what we were doing when it was just --admin, but with multiple defined categories it seems more natural to just make it an argument instead (of course we'd want to preserve --admin for backwards compatibility).

Have fixed the above concerns.

Pull-Request has been rebased

rebased

rebasing and pulling in

Pull-Request has been closed by mikem

Metadata