#510 cli: change download-task to regular curl download
Merged by mikem. Opened by julian8628.
julian8628/koji download-task  into  master

Download 510.patch

to fix issue#455

Also make 301/302 redirect acceptable by download-build & download-task

close pycurl.Curl() after perform()

rebased

1 new commit added

  • cli: add noprogress argument for download_file in download_build

:thumbsup:

@mikem - this one fixes regression with redirects. Can we merge it early?

Minor -- we should avoid printing the extra blank lines when noprogress flag is passed

otherwise looks ok

rebased

Minor -- we should avoid printing the extra blank lines when noprogress flag is passed

fixed now

Found, that XFERINFOFUNCTION is not available in libcurl < 7.32, so it is not working in centos/rhel/epel. Can we add variant for older PROGRESSFUNCTION?

rebased

Found, that XFERINFOFUNCTION is not available in libcurl < 7.32, so it is not working in centos/rhel/epel. Can we add variant for older PROGRESSFUNCTION?

updated

Found, that XFERINFOFUNCTION is not available in libcurl < 7.32, so it is not working in centos/rhel/epel. Can we add variant for older PROGRESSFUNCTION?

updated

Tested, thanks!

Commit c3f6f4f0 fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

Metadata