#526 Added list builds command to koji CLI
Merged by mikem. Opened by breilly.
breilly/koji listbuilds362  into  master

Download 526.patch
no initial comment

When package is not found, opts are set to None. It should fail, as in other case it will fetch all packages.

Same logic as previous one. If parameter is specified, but it is nonsense, command should fail (package/owner/volume).

If buildid is nonexistent, code will fail here.

could nvr as a build be accepted by this command here?

How about also listing "maven version" in result here?
But it looks too long to display in one line :(

Maybe we should check if len(args) != 0 here

I think if opts is empty should be checked before listBuilds executing. It takes too long time to return the data without any filter.

2 new commits added

  • Added more failure handling for list-builds
  • Spelling fixes

rebased

Please accept text value for state (also, handle numeric states correctly)

Let's support the prefix option since the hub does

The help test for the buildid arg should probably be more like "list only this build."

Maybe parse those times client side so we get the local tz right (see list-history for example)

Maybe offer some sorting options

rebased

Looking good overall

Selecting by volume is throwing an error

For sorting options I was thinking more like the option to specify a sort key. I'm not sure the reverse arg is very helpful without that.

Also, playing around with this, it seems like we should really display the state.

Also, the special case output for maven feels a little busy, and it seem odd to special case maven, but not other types. Maybe for now, just use the standard format all around, as the web ui does.

https://github.com/mikem23/koji-playground/commits/listbuilds362

Do you have time to update this?

rebased

thanks!

:thumbsup:

Commit f564c08a fixes this pull-request

Pull-Request has been merged by mikem@redhat.com

Metadata