koji

#533 Treat canceled tasks as failed for optional_archs
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue529  into  master

Download 533.patch

Issue #529

Let's squash the "asdgfd" commit (or edit the message to something useful).

I'm not sure about the return value for canceled builds. Seems like we should either 1) match the fault return format of getResult(raise_fault=False), or 2) just return None

I've added faultCode derived from GenericError, so format is same now.

rebased onto 7a9026f8fbcd566187648a0cd1c60c03666da123

~~I see the rebase, but not the faultCode, and still the "asdgfd" commit message~~

Nm, fetch error on my part
Edited by mikem

AttributeError: type object 'GenericError' has no attribute 'fault_code'

Here's some work I did on this last month that I never got around to posting. Just rebased on top of your work.
It's kind of a pain to set up a system to test this change, so I think unit testing is important to have here.

https://github.com/mikem23/koji-playground/commits/optional-arch-canceled

I don't think this has to land in 1.14, but we should probably prioritize it in 1.15

4 new commits added

  • taskWaitResults: more unit tests
  • taskWaitResults: fix canfail/canceled case when tasks=None
  • add unit test for host.taskWaitResults
  • include faultCode in return for canceled, can-fail tasks

1 new commit added

  • test intermediate calls

rebased onto a0aa142abf0669faab33d586b5ec621ec9b72150

Commit ac2d2c59 fixes this pull-request

Pull-Request has been merged by mikem
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.