#602 don't use /tmp in chroot
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue569  into  master

Download 602.patch

Related: https://pagure.io/koji/issue/569

mock 1.4+ uses tmpfs for /tmp, so it is no longer writable outside of mock.
Use /builddir/tmp instead of /tmp for persistent data.

:thumbsup:

:thumbsup:

rebased onto 451c6d3a5573fcd20ec4cdbe2e391b3ea44d7814

rebased onto 41c7cc95245b147e083c930db32dd8cb90e5779a

rebased onto b5fb990fc72a38aa1539a8d8fa738ee6f03080f0

rebased onto 84ccc5bbab286c561933d106ec5823c425f57d6b

relatively minor, but this will produce a double slash since base starts with one

May have missed one in ApplianceTask

1
2
3
4
for directory, subdirs, files in os.walk(opath):
    for f in files:
        results.append(os.path.join(broot.rootdir(), 'tmp',
                                    directory, f))

Also in same handler...

    # Run appliance-creator
    rv = broot.mock(['--cwd', '/tmp', '--chroot', '--'] + cmd)

fixes for above here:
https://github.com/mikem23/koji-playground/commits/pagure/pr/602

Can we please have this fixed for koji 1.15? This is a serious problem for Mageia's usage of Koji as all we have is Mock 1.4+, and Fedora Infrastructure itself has been holding back Mock upgrades for a while now.

I'm probably going to go ahead and pull these changes into the rebase for Koji 1.14 in Mageia Cauldron, as the changes in @mikem's GitHub fork look okay to me.

@mikem your proposed changes look good to me.

Commit 0f228baa fixes this pull-request

Pull-Request has been merged by mikem

Metadata