Related: https://pagure.io/koji/issue/613
please avoid constructing queries this way. Use the safer parameter method whenever possible.
for now, let's also include groups
or perhaps simply exclude hosts
1 new commit added
rebased onto 002060860e552b83e0fad5ca6388b5cfa642cd21
It seems strange to me to have users.id = build_notifications.user_id as a clause rather than a join condition. I guess they are technically equivalent here, but it seems like it would be clearer to have an explicit join as we do elsewhere.
users.id = build_notifications.user_id
rebased onto 90f760944fb9fb15c0cdd3dd28c720fe7b8e9829
We don't want a left join here
rebased onto 9fc3c16d2f53ac4327c922e9b25562be35fdec00
This changes the return type of this function. While tag_notification simply loops over the result, build_notification passes it verbatim as an option to the buildNotification task. This will break because set objects cannot be represented in xmlrpc. Probably just return list(set(emails))
rebased onto 9c12c2f595c38f77ca0bf458ddc705e0b2c8dbe2
Commit 882f5131 fixes this pull-request
Pull-Request has been merged by mikem@redhat.com
Related: https://pagure.io/koji/issue/613