From 7f302491f971436133da847cd8293c796b135514 Mon Sep 17 00:00:00 2001 From: Yuming Zhu Date: Oct 11 2017 14:52:48 +0000 Subject: use urlparse.parse_qs instead of deprecated cgi.parse_qs --- diff --git a/hub/kojihub.py b/hub/kojihub.py index 8516c76..bcdd282 100644 --- a/hub/kojihub.py +++ b/hub/kojihub.py @@ -24,8 +24,7 @@ import base64 import calendar -import cgi -import copy +import urlparse import koji import koji.auth import koji.db @@ -12666,7 +12665,7 @@ def handle_upload(environ): start = time.time() if not context.session.logged_in: raise koji.ActionNotAllowed('you must be logged-in to upload a file') - args = cgi.parse_qs(environ.get('QUERY_STRING', ''), strict_parsing=True) + args = urlparse.parse_qs(environ.get('QUERY_STRING', ''), strict_parsing=True) #XXX - already parsed by auth name = args['filename'][0] path = args.get('filepath', ('',))[0] diff --git a/koji/auth.py b/koji/auth.py index 3cae076..6f43159 100644 --- a/koji/auth.py +++ b/koji/auth.py @@ -29,7 +29,7 @@ try: except ImportError: krbV = None import koji -import cgi #for parse_qs +import urlparse #for parse_qs from .context import context from six.moves import range from six.moves import zip @@ -78,7 +78,7 @@ class Session(object): if not args: self.message = 'no session args' return - args = cgi.parse_qs(args, strict_parsing=True) + args = urlparse.parse_qs(args, strict_parsing=True) hostip = self.get_remote_ip(override=hostip) try: id = long(args['session-id'][0])