/me finds out there is no subscribe button on PR :(

/me finds out there is no subscribe button on PR :(

https://pagure.io/pagure/issue/1866

In the meantime, we could discuss on the issue instead I guess.

this getattr needs a default or it will fail for many cases

This is running after broot.expire(), which I think sets up a race condition. (As soon as broot is expired, the main kojid process could clear it, and scmdir with it).

I think as long as we're here, I'd like to start populating build.source for all rpm builds, not just rpm builds from git.

Fixed and continuing discussion in #550

@mikem looks like there is no support for non-git SCMs, are there more changes you would like to see?

changes here:
https://github.com/mikem23/koji-playground/commits/pagure/pr/674

@mikem looks like there is no support for non-git SCMs, are there more changes you would like to see?

With the additions above, we will set the source field for any scm, however it is only normalized to include a commit hash with git.

I'm open to doing something similar for other scms, but it is unclear to me quite how that should look. For this PR, git is the main concern.

changes here:
https://github.com/mikem23/koji-playground/commits/pagure/pr/674

I'm unfamiliar with koji's source code, but these changes looks fine to me :)

@tkopecek, do those changes look ok to you?

@mikem your proposed changes look good to me.

Commit cedd6eef fixes this pull-request