#691 option for notifications in untagBuildBypass
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue690  into  master

Download 691.patch

Fixes: https://pagure.io/koji/issue/690

This also changes the default behavior. Previous bypass tag operations did not notify. I believe there are a number of rel-eng scripts that perform mass tagging and I think that quieting notifications is part of the reasons.

But maybe it is better to make the change an notify by default. I'm not sure, but I think we should check with some users before we do this.

Also, seems like we ought to make the same change to tagBuildBypass if we're going this way.

rebased onto f4b532eb4df3c52d0b8aac9a8e2c994b314e96eb

I've added fix also for tagBuild and sent a question to koji-devel.

I don't think the bypass calls should notify in the failure case. This could lead to some some repetitive messages in some cases.

rebased onto b667f73c9c239e7bf15ca8f0e880289df2a768d4

Ok, I think it should work, rebased and updated.

:thumbsup:

merging with a docstring fix

Commit 82907196 fixes this pull-request

Pull-Request has been merged by mikem

Metadata