#707 add argument detection to prevent array out of index error.
Merged by mikem. Opened by franzh.
franzh/koji issue706  into  master

Download 707.patch

Fixes: #706
https://pagure.io/koji/issue/706
add argument detection to prevent array out of index error.

:thumbsup:

Fixes: #706
https://pagure.io/koji/issue/706
add argument detection to prevent array out of index error.

I'd prefer to have a descriptive subject for commit messages.
It's fine, helpful even, to have "Fixes: #706" in the body of the commit message, but the subject needs to tell the reader what the change is.

Also, you have multiple lines here with no blank line separator. Some tools with summarize with your first line, but others (notably git log) will catenate these lines, making an overly wide summary.

$ git log -1 --oneline
65eb3781 (HEAD -> pagure/pr/707) Fixes: #706 https://pagure.io/koji/issue/706 add argument detection to prevent array out of index error.

E.g. a slight rearrangement of what you have:

add argument detection to prevent array out of index error.

Fixes: #706
https://pagure.io/koji/issue/706

rebased onto 5da7c18f1fc94e5eae6e6a52866921faf7891643

@mikem
Thanks for your suggestion, I have updated my commit message.

Commit 39dc9efa fixes this pull-request

Pull-Request has been merged by mikem

Metadata