#711 Drop explicit python-krbV dependency for modern platforms
Merged by mikem. Opened by mikem.
mikem/koji python-krb-soft-dep  into  master

Download 711.patch

Our original kerberos authentication mechanism (non-gssapi) requires the python-kerberos package. We have also supported gssapi authentication since last year.

The python-krbV package is dead upstream and will retired in Fedora, so we need to phase it out in Koji. This change removes the explicit dependency. Koji will can still use the package if it is present, but will not error if it fails to import.

Is there a reason why if krbV: doesn't suffice? Since if that evaluates to True, it's loaded?

Just one nitpick, but otherwise this PR looks good to me. :thumbsup:

I was simply going for minimal perturbation, but you're right that this could be simplified

1 new commit added

  • simplify check for krbV module

:thumbsup:

Commit 87e23fa6 fixes this pull-request

Pull-Request has been merged by mikem

Metadata