#765 search build by source
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue701  into  master

Download 765.patch

Fixes: https://pagure.io/koji/issue/701

Interesting. I'd expected this would be added to the listBuilds call instead.

Does it make sense to add it to both or would you prefer listBuilds? When I'm looking to it now, I think both calls could support it, but maybe listBuilds is a little bit more appropriate.

I think, for now at least, it fits best in listBuilds. So far, the search call is for finding things by their name or primary descriptor, whereas listBuilds is for finding builds that match some conditions. We might expand the scope of the search call in the future, but I think i'd leave this out of it for now.

rebased onto 4b142dfe206709843a543a0501417d5059a7c2ce

rebased onto 59abc829f19c8e134f231a8ce7cf80f0d61cb744

I started to tweak the docstring addition and ended up cleaning up the whole thing:

https://github.com/mikem23/koji-playground/commits/pagure/pr/765

:thumbsup:

Commit 50d02cdc fixes this pull-request

Pull-Request has been merged by mikem

Metadata