#777 add debug timestamp log for logs
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue776  into  master

Download 777.patch

Fixes: https://pagure.io/koji/issue/776

Does this make sense? I would also add a config option if we want to go this way.

I wonder about having it all in one file. It is definitely simpler, but this forces us to put the filename on each line. Seems like a lot of duplication.

Perhaps ts_offsets instead of ts_state?

Do we need the header in the file?

Should we make our granularity configurable?

The %f format for the time seems like overkill. We can never be that granular. Might be best to just use %.0f.

At some point (probably as follow-on work), we might want to add some code that can combine the timestamp data with the logs on the fly, perhaps even have the web offer that option.

3 new commits added

  • make timestamp logs configurable
  • split timestamp log to multiple files
  • wip

rebased onto d285c5e19f95c1c4ddc51ed794b7cb32f00a2952

Rebased due to merge conflict, added split logs and configuration. Also fixed some problem with multiple opening of ts.log leading to non-monotonous values.

Commit d9682472 fixes this pull-request

Pull-Request has been merged by mikem

Metadata