PR#802: omit the last dot of cname when krb_canon_host=True -

koji

#802 omit the last dot of cname when krb_canon_host=True

Merged Feb 28, 2018 by mikem. Opened Feb 7, 2018 by julian8628.

julian8628/koji krb-canon-host into master

julian8628 commented Feb 7, 2018

fixes: #801
relates: #653

julian8628 commented Feb 7, 2018

@mikem @eberdnik

mikem commented Feb 28, 2018

My only concern is that we may encounter fairly old versions of this library on rhel. Are we confident that this option will exist (and work the same) on those versions? A quick glance at the upstream code seems to say yes (looks like this option was in the initial git import from 2005 and goes at least as far back as v1.3.4.

So :thumbsup: , but I think we should get qe to verify this on rhel as part of release testing.

mikem commented Feb 28, 2018

Commit 29aeb5f0 fixes this pull-request

Pull-Request has been merged by mikem

Feb 28, 2018