koji

#83 add support for putting scripts just before the closing tag
Merged by mikem. Opened by rayson.
rayson/koji bottom_template  into  master

Download 83.patch

Allow themes to insert scripts to the bottom of the generated HTML files.
See https://developer.yahoo.com/performance/rules.html#js_bottom .

Is the existing localfooter not good enough?

Is the existing localfooter not good enough?

@mikem

Modern browsers are smart enough and won't block the rendering process before seeing the closing </div>s.

For Koji it is okay to place <script> tags to localfooter since there is no additional open tags or content after that. And some profiles I did show it makes no difference.

Placing scripts to the bottom of the page is just to ensure all DOM elements are loaded before these scripts for old browsers.

What do you think?
Edited by rayson

Commit 10b6d1c3 fixes this pull-request

Pull-Request has been merged by mikem@redhat.com
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.