#831 Use unittest2 for rhel6 compatibility
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue830  into  master

Download 831.patch

Fixes: https://pagure.io/koji/issue/830

rebased onto 427843692cf4b96637a0fdb33bf5b84b2e2ad2f2

Recent tests need updating. I've rebased again and applied those fixes here:

https://github.com/mikem23/koji-playground/commits/pagure/pr/831

This leaves a few broken tests on el6, at least when I try.

With a few more updates on that branch I can get the tests to pass

PYTHONPATH=hub/.:plugins/hub/.:plugins/builder/.:plugins/cli/.:cli/.:www/lib /usr/bin/nosetests

Though I do get a deprecation warning:

/usr/lib/python2.6/site-packages/unittest2/case.py:326: DeprecationWarning: Use of a TestResult without an addSkip method is deprecated
  self._addSkip(result, skip_why)

The deprecation warning seems to be this issue:

https://stackoverflow.com/questions/10991198/using-unittest-skipif-with-older-versions-of-python/10992651

And now that is fixed on the playground branch too...

I'm planning to merge this for 1.16, but I'm holding off until tomorrow in the event that any other merges add a unit test that needs the import updated.

rebased onto 2cacce39700abfe50839ed5a0b34d80e01485166

rebased onto 2287368c0784cf62365b9834d370b258f2cfbc49

I need these changes to get the tests to succeed in an el6 env:
https://github.com/mikem23/koji-playground/commits/pagure/pr/831

If those look ok, I can merge in the morning.

Yes, works for me. It worked for me before, as I've used same env as jenkins have, which means some packages updated via pip.

2 new commits added

  • avoid skipIf in import-comps unit test
  • more unit test fixes

Commit 7e5a8a51 fixes this pull-request

Pull-Request has been merged by mikem

Metadata