PR#848: use subprocess.Popen instead of subprocess.check_output - - Pagure.io

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

koji

#848 use subprocess.Popen instead of subprocess.check_output

Merged Mar 16, 2018 by mikem. Opened Mar 14, 2018 by julian8628.

julian8628/koji fix-subprocess into master

Download 848.patch

julian8628 commented Mar 14, 2018

to make it supported on py2.6
fixed #846

3 new commits added

do not shell=True
unittest for scm.get_source
fix subprocess.check_output for py2.6

Mar 14, 2018

julian8628 commented Mar 14, 2018

@mikem @tkopecek Please review

tkopecek commented Mar 14, 2018

:thumbsup:

mikem commented Mar 16, 2018

Commit be80208c fixes this pull-request

Pull-Request has been merged by mikem

Mar 16, 2018

Metadata

Assignee

None

Tags

No Tags

Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.