koji

#864 Ensure log output is produced if config file is unreadable
Closed by tkopecek. Opened by rwphillis.
rwphillis/koji log-unreadable-config-file  into  master

Download 864.patch

Hi Team,

During a recent test deploy of a new koji-hub host, I discovered that no logging is produced if the main configuration file (/etc/koji-hub/hub.conf) is unreadable.

In my case, an overly restrictive user/group/mode combination rendered the file unreadable by the apache user:

[richard@host:~]# ls -l /etc/koji-hub/hub.conf
-rw------- 1 koji koji 4003 Mar 27 10:17 /etc/koji-hub/hub.conf
[richard@host:~]#

Attempting to connect to this koji-hub instance via koji-client yielded the following error:

ServerOffline: database outage

Due to a lack of logging (and perhaps caffeine), I didn't initially spot the user/group/mode blunder.

This pull request seeks to ensure that suitable logging is produced in the event that the configuration file is not readable. This is particularly important, as koji-hub's default behaviour upon being unable to read the configuration file is to coalesce a number of configuration file parameters, with values that will result in koji-hub failing to operate.

Thanks! :)

I've created issue #865 and PR #866 for consolidating this behaviour through all places. It should satisfy also this case.

Obsoleted by #1296

Pull-Request has been closed by tkopecek
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.