PR#902: Added editUser api call -

koji

#902 Added editUser api call

Merged Oct 14, 2019 by tkopecek. Opened Apr 23, 2018 by breilly.

breilly/koji useredit-862 into master

breilly commented Apr 23, 2018

As 'status' is handled by enable/disable user and user_perms are handled elsewhere, only included renaming and krb_principal here.

tkopecek commented Apr 24, 2018

Can we get some tests?

@mikem What is your opinion on future use of _dml? Are we going to use Insert/UpdateProcessor where possible, or is it still ok to use _dml for such simple queries?

1 new commit added

Added edit_user unit tests

Apr 25, 2018

2 new commits added

Added edit_user unit tests
Added editUser api call

Apr 25, 2018

mikem commented Apr 30, 2018

@mikem What is your opinion on future use of _dml? Are we going to use Insert/UpdateProcessor where possible, or is it still ok to use _dml for such simple queries?

Yeah, don't use _dml() in new code if at all possible. There may be exceptions, but this case is clearly a job for UpdateProcessor.

rebased onto a83c1d6df50168e5e86d3efe57c2bc68f916746a

May 2, 2018

tkopecek commented May 16, 2018

:thumbsup: you can also use QueryProcessor here, but it is a simple one.

dgregor commented Jun 20, 2019

Fixes: https://pagure.io/koji/issue/862

Metadata Update from @breilly:
- Pull-request tagged with: testing-ready

Oct 4, 2019

julian8628 commented Oct 9, 2019

I think it's better to use obvious arguments than **kwargs

Metadata Update from @jcupova:
- Pull-request tagged with: testing-done