:thumbsup:

rebased

:thumbsup:

I get a unit test failure with the current version

  File "/tmp/tmpKZhq0j/tests/test_hub/test_rpmdiff.py", line 93
    defattr = [19L, 33188, 1531970408, 0, 0, 2, 1, -1, -1, 'root', 'root', '02d2c91b']
                 ^
SyntaxError: invalid syntax

I guess the jenkins tests are not running all the py3 tests?

Fixed. Problem with jenkins is that it is not running py3 tests at all. I've to figure out, how to run both and don't mix results.

@tkopecek
I found koji.get_rpm_header() will return different result between py2 and py3, because of the differences of the string/byte types.
like the case in PR #1068, should we make the result to only contain strings?

@julian8628 - I've more related changes here https://pagure.io/fork/tkopecek/koji/c/13d956f0a6069ce08fb91019aff7bdf782f54a5e?branch=builder-py3 It probably makes sense to pull it out and create separate PR for that (correct decoding of headers and unified usage of that)

^ PR #1070 / issue #1069

rebase

This seems to break the upgrade path. Rpm doesn't know that python2-koji-hub should replace koji-hub

Is there a reason we should be shipping both versions of the hub? To me, it makes sense to only ship Python 3 components when Python 3 is enabled for stuff that isn't importable modules.

And doing so will drastically simplify the packaging...

What's the status here? Moving to python3 would be very welcome because of the python2 deprecation in F30.

/cc @churchyard

...and yum removal.

I've incorporated few more fixes and revamped packaging for cleaner upgrade path. @mikem, can you check it?

The spec isn't quite where I want it, but I'm going to merge this as-is and deal with that in a separate PR once I merge all three of the main py3 changes.

Commit 2460a001 fixes this pull-request