koji

#995 copy data from static variable instead of use it directly to prevent caching.
Closed by mikem. Opened by franzh.
franzh/koji issue994  into  master

Download 995.patch

copy data from static variable instead of use it directly to prevent caching.

also update test cases to verfiy this issue.

Fixes: #994
https://pagure.io/koji/issue/994

Can be simplified to
FILEIDX = self.__FILEIDX[:]

FILEIDX = self.__FILEIDX[:] copies the reference of the elements in self.__FILEIDX, similar to shallow copy does. But we need to copy and create new instance for each elements in the FILEIDX, more like deep copy.
So this doen't work for this issue.

ah, you're right

PR #997 is based on this one and fixes another issue
Edited by tkopecek

1 new commit added

  • fix skip option 'S' in rpmdiff does not work issue

@tkopecek
Thanks for your solution to fix 'S' option.
Here I purpose a simple design for the ignore option check, please review it.

2 new commits added

  • fix skip option 'S' in rpmdiff does not work issue
  • copy data from static variable instead of use it directly to prevent caching.

2 new commits added

  • fix skip option 'S' in rpmdiff does not work issue
  • copy data from static variable instead of use it directly to prevent caching.

I wonder, that dropping these still leaves test working (especially comparing hashes). Entries needs to be cleaned, so they produce same hash with same ignore flags (and different for different flags).

@tkopecek
Thanks for reminding, I've added back entries clean up statements.
I also added kojihash() test in test cases.

2 new commits added

  • fix skip option 'S' in rpmdiff does not work issue
  • copy data from static variable instead of use it directly to prevent caching.

Using changes from #997 (see discussion)

Pull-Request has been closed by mikem
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.