#997 Fix rpmdiff's ignoring of size
Merged by mikem. Opened by tkopecek.
tkopecek/koji issue994a  into  master

Download 997.patch

entry[1] = -entry[1] - 100

The reasons here are somewhat non-obvious and I think this at least deserves a comment.

I wonder if there is a better, clearer way to handle this. We set up FILEIDX early on, but only use it at the end.

Changes here: https://github.com/mikem23/koji-playground/commits/pagure/pr/997

I like mike's changes, actually I have done similar change in my PR: #995. I would like to use mike's solution since its variable name is more straightforward.
By the way I noticed that self.ignore is initialized but never use afterwards, should we keep it ?

I noticed that self.ignore is initialized but never use afterwards

My changes above remove it. I did this mainly to avoid confusion with the local ignore var. Probably a relic from the original code.

@tkopecek what do you think?

I wonder if I should make this a separate PR since my changes replace most of the previous ones (except for the new unit test).

Yes, we can drop this one. Look also to #995 solving same problem.

I'll just use this PR with the update changes. merging shortly

Commit 05e79137 fixes this pull-request

Pull-Request has been merged by mikem

Metadata