You're assuming all koji instances are using https, I could see some using http behind a firewall

Thanks. Fixed.

What about using urlsplit + parse_qs? I'm thinking about potential changes in url (which is unlikely), but then you can be sure, that this is really taskID, not some other argument. regexp could be another solution.

I've also created issue #1004, so we've tracked it as a new feature. Please reference it in commit message (Fixes: https://pagure.io/koji/issue/1004)

I am not sure it is worth to spend too much time on this small change until there is another URL that download-task is unable to process. In ideal world it is dnf task to extract potential package info from any URL, validate that the package came from authoritative source (signed by koji at specified datetime) and install it.

Like I want to install testing packages from bodhi, scratches from koji etc. So that URL detection logic may end up in a separate function that could be pasted to dnf as-is, but it will require few more days for engineering, which I lack.

:thumbsup:

So how do we proceed? Is there enough code for a merger now? :D

Yes, @mikem is doing the merges and he should be online in the end of the week.

Will it confuse people that the actual remote server is not the same as the one in URL?

This feels like a questionable feature. Why is the url easier to copy/paste than the id? Can we address that instead?

This feels like a questionable feature. Why is the url easier to copy/paste than the id? Can we address that instead?

No answer. Where are folks typically copying the urls from that the id is unavailable?

This feels like a questionable feature. Why is the url easier to copy/paste than the id? Can we address that instead?

@mikem because Right-click + Copy Link Location is faster than Select + Right-click + Copy.

Rebased to fix merge conflicts.

I still don't think this is a needed change.

While the patch in this PR appears to be relatively simple, it makes the handling of command line arguments inconsistent with other commands. It opens the door to much more significant changes in order to do the same thing for all command args that might also have an associated url, not just the ten or so commands that accept task ids but also build ids, rpm ids, tag ids, host ids, etc.

because Right-click + Copy Link Location is faster than Select + Right-click + Copy.

This is simply not enough justification for this change.

As far as I can tell, in all places where a task url shows, the task id also appears independently in a place that is easy to select. I can easily select the id with a double click and then copy/paste.

If there are places in the ui where the task id does not appear when it should, or is unduly difficult to select, we can look at changing that. However, we're not going to take this change.

I rebased https://pagure.io/fork/abitrolly/koji/tree/downurl in case you'd need some UX worms.