#13 Moved external licenses check into response pre-processing, in order to avoid filterResponse() as much as possible (fixing issue #11)
Merged by quidam. Opened by gioma1.
gioma1/librejs fix/out-of-memory  into  master

Download 13.patch

This fixes issue #11, which appears to be caused by a deeper Mozilla bug in WebExtensions' webRequest.filterResposense() API, causing cached script requests, if rewritten, to be cached as UTF-16 corrupted by a binary preamble, which breaks everything afterwards and especially the TextEncoder, chocking with out of memory.

I'll investigate further and file a report Mozilla's tracker as soon as I've got time (I'm quite swamped among librejs and Tor Browser 8), but moving external license checks earlier, in response pre-processing, suffices as a work-around and also wins us some nice performance points.

1 new commit added

  • Fixed weblabels not being checked in whitelisted documents unless they precede scripts.

Pull-Request has been merged by quidam

Metadata