What is this?

well the details are in https://pagure.io/fedora-workstation/issue/362 but basically the Anaconda Web UI installer is currently blocking on gnome-initial-setup taking on some of the configuration for live images. These changes are necessary to allow for that.

I think neal meant specifically "why is there a 'cut here' line?"

oh weird, i'm pretty sure pagure just said

"ngompa commented"

and not

"ngompa commented on line 66 of libexec/livesys/sessions.d/livesys-gnome 21 minutes"

before.

That's called a bash HERE document. It's a way of writing a file from within a bash script. The delimiter to mark the end of the HERE document was previously "FOE" but because i moved the document it into a conditional I wanted to also indent it. That required changing the delimiter to have leading spaces and the content to have leading tabs. Since I was changing the delimiter anyway, I made what I felt was a more intuitive one... a cut line instead of the letters FOE (which is a little obscure, it means END OF FILE but spelled backwards as a nod to bash that has some of its own blocks end with words spelled backwards)

We use the "FOE" convention pretty consistently elsewhere in this repo:

[adamw@xps13a livesys-scripts (main)]$ grep -R FOE * | wc -l
36

so it might be best to stick with that?

well I can't if I want to indent the document.

Or is your opinion that consistency in delimiter naming trumps even in the face of bad indentation ?
I could also use " FOE" instead of "FOE". that's kind of a middle ground. i'm okay with whatever

Also, just to give some rationale behind the change (and not the subjective style bits) in case that's what neal was actually getting at... gnome-initial-setup will ask for a username if an overlay image is being used instead of using "liveuser". So we can't enable automaticlogin in that case.

I'm fine with it, I have just never seen that before.

i ended up switching to " FOE" because i needed to add commit a30976376ef4783725c1f9207ccbe7d48c5a024a to fix another issue, and so i'm left with the choice of which delimiter to pick again, and all of a sudden adamw's plea for consistency starts to resound more :-)