The new KDE Plasma Mobile Spin needs it's own livesys-scripts.
Signed-off-by: Troy Dawson tdawson@redhat.com
This looks good to me. That said, this looks really similar to the main kde one, is there a way we can deduplicate things so that this is easier to maintain long-term?
You are correct. There is really only two changes.
1 - Adding the stuff for the liveinst.desktop on mobile desktop This could be added to the regular kde, it wouldn't hurt, just an extra config file.
2 - Changing the default autologin. I don't know how to do an "if" in a livesys. Would something like this work.
if $(rpm -q plasma-mobile > /dev/null 2>&1) ; then DEFAULT_DESKTOP="plasma-mobile.desktop" else DEFAULT_DESKTOP="plasma.desktop" fi
Yes. That would work fine.
It's just a bash script, it works like you think it does. :smile:
rebased onto 58c15e32b110ba8af4318407b1511e1b0dab23b6
I forgot about the little /bin/sh at the top. :)
I like having them combined better.
Let's make this conditional on plasma-mobile being installed too.
If we turn this into a flag variable, we can reuse the value for this conditional and further down for the other part. :)
Very good point. Done
Does this need to be in /usr/share or is there a way to put this in somewhere in ~liveuser/.config? Writing random stuff into /usr/share seems fishy to me...
/usr/share
~liveuser/.config
From what I can see, yes. I originally tried it in ~liveuser/.config and it would get overwritten. '/usr/share...' was the only way to do it. I do have a concern about it being there after the install, but I have not been able to verify that yet.
Yeah, that's one reason I'm concerned, I'm pretty sure it'll get rsynced to the final installed system.
1 new commit added
Cleanup mobile
How about this. It cleans it up after the anaconda install.
That'll work for now. Can we get a bug filed with plasma-mobile about this so we can eventually get rid of the snippet?
Yes, I could file a bug. Just know that it's going to take a bit of time to do it. Most likely sometime later next week.
rebased onto e337cdeb4be5f68857bcd8eb2afbf01cae982172
Pull-Request has been merged by ngompa
The new KDE Plasma Mobile Spin needs it's own livesys-scripts.
Signed-off-by: Troy Dawson tdawson@redhat.com