newt

#21 cleanup configure.ac and Makefile.in
Closed by mlichvar. Opened by thomas_kuehne.
thomas_kuehne/newt master  into  master

Download 21.patch

in configure.ac:
- update AC_INIT and AC_CONFIG_HEADER handling
- add missing AC_PROG_[...]
- replace backquoted command substitution `cmd` with clean $(cmd)

in Makefile.in
- swap order of LDFLAGS and P*FLAGS

Adding AC_PROG_INSTALL to configure.ac seems to break the configure script for me on Fedora:

$ ./configure 
checking for gcc... gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... no
checking for suffix of object files... o
checking whether we are using the GNU C compiler... yes
checking whether gcc accepts -g... yes
checking for gcc option to accept ISO C89... none needed
checking whether ln -s works... yes
checking for grep that handles long lines and -e... /usr/bin/grep
checking how to run the C preprocessor... gcc -E
configure: error: cannot find install-sh, install.sh, or shtool in "." "./.." "./../.."

The file can be added by automake --add-missing but this is not an automake project.

Any suggestions?

I pushed the commits except the one causing the issue mentioned above. If you find some way to address it, please submit a new PR.

Thanks.

Pull-Request has been closed by mlichvar
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.