#1157 Drop redundant Source and Patch numbers
Merged by james. Opened by churchyard.
churchyard/packaging-committee nonumbers  into  master

Download 1157.patch

See https://lists.fedoraproject.org/archives/list/packaging@lists.fedoraproject.org/thread/BG5SVFAKGNVDJFHGZARABWGW2RRHN22G/

Since RPM 4.15, numbering Sources and Patches is redundant.
I've left the numbers in examples where they matter.

Note that it might be confusing if people want to access sources by their variables, because those are still numbered.

Metadata Update from @james:
- Pull-request tagged with: meeting

This sentence suggests to write "%gem_install -n %{SOURCE0}". You're changing that to "%gem_install -n Source". That won't work, will it?

No, it won't.

I wonder why you replace Patch0 / %patch0 with Patch1 / %patch1 here? Doing the same thing for patches as four sources should make this "Patch" and %patch0, right?

rebased onto af05438b2dbcb16b2da719540b4478674af31fd0

Both changes were an oversight. Removed.

@decathorpe I want to avoid examples combining Patch: and %patch0 -- if you need to reference a patch by its number, better hardcode that number.

I'm not seeing any reason not to merge this at this point, though it's still tagged meeting and I don't recall how much discussion there was.

Metadata Update from @churchyard:
- Pull-request untagged with: meeting

rebased onto b1dfec6d79ec567ba185296f0409ea12fc701ae2

Untagged, rebased.

This doesn't make sense when other sources are numbered.

This doesn't make sense when other sources are numbered.

I don't necessarily agree, but if this is the only blocker, I can revert that bit.

rebased onto f4524a38fef8ed519518f3dedc232c54a66d017b

@ngompa Removed.

rebased onto db7a00438a8add5ba0364e48b2b0f6451202b129

rebased onto e212e28efffa2d6380a823764d4245585936bd86

Pull-Request has been merged by james

Metadata