From b488336acf856876f69b4d6c06c055155fd8506a Mon Sep 17 00:00:00 2001 From: Zbigniew Jędrzejewski-Szmek Date: Feb 13 2025 17:12:05 +0000 Subject: review: drop obsolete recommendation for file path dependencies In 8ee8319f86af93a057ad6ad73c9b1addf8df5574 we forbid file path dependencies outside of /usr/*bin and /etc. f80e2dc64197d88821fdaae53f297f4f4315cd97 simplified that to just /usr/bin and /etc. The review checklist says earlier that Packaging Guidelines must be followed, so this recommendation is now fully duplicate (and misleading). --- diff --git a/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc b/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc index a75255f..0988b09 100644 --- a/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc +++ b/guidelines/modules/ROOT/pages/ReviewGuidelines.adoc @@ -55,7 +55,6 @@ There are many many things to check for a review. This list is provided to assis * [[sane-scriplets]] *SHOULD*: If scriptlets are used, those scriptlets must be sane. This is vague, and left up to the reviewers judgement to determine sanity. See xref:index.adoc#_scriptlets[Packaging Guidelines: Scriptlets] + * [[subpackage-versioned-requires]] *SHOULD*: Usually, subpackages other than devel should require the base package using a fully versioned dependency. See xref:index.adoc#_requiring_base_package[Packaging Guidelines: Requiring Base Package] + * [[pkgconfig-in-devel]] *SHOULD*: The placement of pkgconfig(.pc) files depends on their usecase, and this is usually for development purposes, so should be placed in a -devel pkg. A reasonable exception is that the main pkg itself is a devel tool not installed in a user runtime, e.g. gcc or gdb. See xref:index.adoc#_pkgconfig_files_foo_pc[Packaging Guidelines: Pkgconfig Files] + -* [[file-requires]] *SHOULD*: If the package has file dependencies outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin consider requiring the package which provides the file instead of the file itself. See xref:index.adoc#_file_and_directory_dependencies[Packaging Guidelines: File and Directory Dependencies] + * [[man-pages]] *SHOULD*: your package should contain man pages for binaries/scripts. If it doesn't, work with upstream to add them where they make sense. See xref:index.adoc#_manpages[Packaging Guidelines: Manpages] + == A note on dependencies