pagure-dist-git

#148 Extend take_orphan endpoint to accept fas username in POST data
Closed by humaton. Opened by humaton.
humaton/pagure-dist-git extend_take_orphan  into  master

Download 148.patch

Fixes: releng#10394

Signed-off-by: Tomas Hrcka thrcka@redhat.com

rebased onto 0f770d5a5d239495b21885817de982af177ac7f5

if fas_username is not passed onto the request, args.get() above will return None and Non.exists will not work.

Could you expand on the use-case for this change?

Currently, when releng is un-retiring packages we do it using the PATCH HTTP method to set the projects main_admin. As mentioned in the issue I have linked this is causing to leave orphan_reason in the database. By updating this endpoint and releng scripts this should be fixed.
Edited by humaton

rebased onto 45bbf86e2372a38f47f6e976c67ef9359cbfe971

rebased onto 1b252696d889d734dacc341fcb8a2fb839b629fa

if fas_username is not passed onto the request, args.get() above will return None and Non.exists will not work.

Ups, it should be fixed now.

Don't we want that only rel-eng and admin users are able to assign a package to others?

I started to write a separate endpoint for this, but then I stopped due to lack of time trying to make test works:
https://pagure.io/fork/mattia/pagure-dist-git/c/a0d34d5160ad77dd4736b41f762713caf7736fda?branch=unretire

@mattia I have troubles with getting tests running as well, let me pick up your new endpoint and get the tests running.

Pull-Request has been closed by humaton
Metadata
None
No Tags
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.