pagure-messages

#9 The `url` property is wrong on dist-git
Closed by abompard. Opened by abompard.

Closed
Reopen Issue

This is a re-report of https://github.com/fedora-infra/fmn/issues/905.

In base.PagureMessage, the get_base_url function hardcodes pagure.io or stg.pagure.io. There would be a way to avoid it using self.body["repo"]["full_url"] instead.
I'll submit a PR soonish.

I wonder if the original idea wasn't to have a subclass of PagureMessage for dist-git that just overrides the __link__ and __stg_link__ variables

Hmm, possible, but then how would subclasses, as they are instantiated by the Pagure code, select which PagureMessage variant to inherit from? It seems safer to just use full_url, as it's there already.

Fixed by #10

Metadata Update from @abompard:
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.