#1111 [RFE] add git submodules handling/hyperlinking
Closed: Fixed Opened by jpokorny.

Again, something that cgit and GitHub implement a bit better.

Scene setting:

In clufter project, I have misc/git-distill-spec path serving as
a (sort of) mount point, in terms of git submodule, for a separate
distill-spec project.

pagure.io (https://pagure.io/clufter/blob/master/f/misc):

  • correctly displays the commit hash for the respective submodule
    within git-distill-spec (b774f3)
  • does not indicate it's a submodule in any way
  • https://pagure.io/clufter/blob/master/f/misc/git-distill-spec
    link leads to Page not found (404)

cgit:

  • shows:

    m--------- misc/git-distill-spec @ b774f32 0 log stats

GitHub (https://github.com/jnpkrn/clufter/tree/master/misc):

  • same as cgit (graphically indicates it's not a standard file)
  • I vaguely remember that submodules were hyperlinked if the path
    was resolvable, perhaps it doesn't work (or no longer as security
    precaution?) with relative paths that I am using in the referenced
    case

How does this look to you?

pagure_link_submodules.png

Or rather:

pagure_sub_modules.png

Yes, distinguishing submodule graphically would be great and also a minimum expected change. I've just noticed that symlinks (e.g., https://pagure.io/clufter/blob/master/f/root/project) are also not visually different. It would be preferable to have different icons for the two.

It's also a question if there should be some kind of semantic-aware hyperlink (follow the symlink or even submodule path within paguire.io if resolvable).

If you check the screenshot above you'll see that both link and sub-modules now have a different icon :)

Oh, true. I thought that what looks like two question marks denote just "not a regular file".

Oh, true. I thought that what looks like two question marks denote just "not a regular file".

According to the doc it means "broken link" :)

Source: https://useiconic.com/open

Metadata