#1295 Images in don't render in markdown
Closed: Invalid Opened by jflory7.

Problem

Images don't embed properly using the markdown format for images (i.e. ![Description](link to screenshot)).

Analysis

It appears some kind of logic is in place for rendering images using this format, as you can see below…

Example image

But it just makes a specially-wrapped text box that displays the optional description / subtitle for the link. It appears this feature of markdown is broken in Pagure.

Implementation suggestion

I'm not sure on what this issue may be or how it can be fixed…


This is actually by design, embedding images from remote/unknown sources can lead to security issues.

If you want to add an image, just drag/drop it in the comment area and it'll show up in your comment.

@pingou Oh, hmmm… what about serving images through some kind of proxy? Even if that's not a feature desireable for our hosted instance on pagure.io, I think it would be an ideal option for an administrator to offer the ability for users to embed images in Pagure, if the administrator has set up a proxy for images (similar to how some forum software packages do it).

I'm not exactly an expert in the area, but this would put aside the security issues of embeddable images, right? I'll take to uploading images for now on, but this was a nice thing Trac + other VCS platforms have for convenience of sharing images quickly.

Discussing with @puiterwijk we came to the conclusion that using a proxy layer wouldn't gain us much unless we actually process all the images uploaded to it.

In addition, using a proxy layer would make it much harder to run your own instance of pagure.

So I'm going to close this ticket as invalid for now and we can always re-consider if we can figure a good/better solution.

Thanks for the report thoguh, as usual, they are pretty good :)

@pingou changed the status to Invalid

Metadata