pagure

#1313 Fix emoji
Closed: Fixed Opened by pingou.

Closed: Fixed
Reopen Issue

Since 2.5 the emojione JS files have been updated and it looks like we missed some things during the upgrade:

  • emoji once rendered look huge: :wink: see what I mean?
  • the drop-down panel doesn't preview the emojis anymore :(

@pingou
Just have to resize the emoji in respect to the font-size.

But the emoji portion is not working in my local environment.
Giving the error emoji_complete is not defined and the preview option is also not working.

emoji_complete is defined in pagure/static/emoji/emojicomplete.js

Was it determined whether this would be fixed or left as-is? I remember seeing some discussion in IRC about it becoming a feature, but I think the larger emoji are distracting when they're in the middle of a line and cause weird spacing issues in comments. There was also some talk about making emoji large when they're on a line by themselves which would be fine, but I think it would be best to revert this to the original behavior.

Fixed by @cverna in #1475

@pingou changed the status to Closed
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.