#1564 Tests: add a forked project to the 'standard' projects set, refactor tests that roll their own
Closed: Won't Fix by wombelix. Opened by adamwill.

There are now quite a few tests that set up a 'forked' project of their own for testing. Here they are, with the properties of the forked projects they create: user_id, name, description, parent_id.

  • test_pagure_lib_git.py:
    1, test2, test project #2, 1
    1, test3, test project #2, 1
  • test_pagure_lib_model.py:
    1, test, test project #1, 1
  • test_pagure_lib_notify_email.py:
    2, test, test project #1, 1
  • test_pagure_lib.py:
    2, test, test project #1, 1
    2, test2, test project #2, 2
    2, test, test project #1, 1
  • test_zzz_pagure_flask_ui_old_commit.py:
    1, test3, test project #3, 1

There are various other tests that deal with forked projects and forking, but they all do something more in-depth and probably wouldn't use a shared fixture.

It would probably make sense to add one or two forked projects to the set of projects created by create_projects in tests/__init__.py, and adjust the listed tests to use those.


create_projects_git would also need adjusting, I believe.

Metadata Update from @pingou:
- Issue tagged with: RFE, unit-tests

The last update was 6 years ago, no further requests, updates or actionable tasks since then, I'm going to close this issue for now to reduce our backlog.

Metadata Update from @wombelix:
- Issue close_status updated to: Won't Fix
- Issue status updated to: Closed (was: Open)

That one is likely still valid

Make sense, I would bring up the argument as in https://pagure.io/pagure/issue/1576 why it should probably still be closed for now in favor of getting a better overview of the backlog and moving forward upcoming releases.

Metadata