pagure

#1692 Multiple comment boxes show in a pr.
Closed: Fixed Opened by rahulbajaj.

Closed: Fixed
Reopen Issue

While making an inline-comment on the #request_diff page in a pr, if you press comment button 2 times or 3 times simultaneously it opens 2 or 3 comment boxes respectively.

Screenshot_from_2016-12-26_04-01-19.png

Can you reproduce this? I can only if I double/triple click really quickly, if I click at a regular speed it behaves as expected.

Apparently, this also happens in case of a moderately slow connection.

Steps to reproduce:

  • Visit a random PR page's diff tab: https://pagure.io/pagure/pull-request/1813#request_diff
  • Open Developer Tools > Network and throttle the network speed to a slower rate (This is in Google Chrome. Use an equivalent option if you're on Firefox).
  • Click on one of the inline-comment icons repeatedly.
  • Find as many boxes opened.

i was just going to report this bug - it is 100% reproducible with a slow connection

Metadata Update from @ryanlerch:
- Issue assigned to ryanlerch
- Issue set to the milestone: 5.2

Metadata Update from @ryanlerch:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

Fixed in https://pagure.io/pagure/pull-request/4045
Metadata

bug

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.