pagure

#1728 Add unit-tests for failing to create a new token
Closed: Fixed Opened by pingou.

Closed: Fixed
Reopen Issue

In https://pagure.io/pagure/pull-request/1725 @cep improved the documentation and behavior when someone tries to create a new API token for a project.

We should make sure this is cover in the unit-tests.

This seems to be covered already at https://pagure.io/pagure/blob/master/f/tests/test_pagure_flask_ui_repo.py#_3090

Am I right?

Yup, we just need to make sure the error message is actually returned to the user :)

The already-existing tests (mentioned in my previous comment) pass:

Test the add_token endpoint. ... ok

The user is shown an error message using flash. Ref: https://pagure.io/pagure/blob/master/f/pagure/ui/repo.py#_1815

@pingou Is this behaviour sufficient, or do we need to add something more?

The user is shown an error message using flash. Ref: https://pagure.io/pagure/blob/master/f/pagure/ui/repo.py#_1815

Yes, and the test doesn't check if the message was actually shown or not

Fixed by @cep in https://pagure.io/pagure/pull-request/1750

@pingou changed the status to Closed
Metadata

unit-tests

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.