Issue #2221: Suport tables in Markdown - pagure

pagure

#2221 Suport tables in Markdown

Closed: Fixed Apr 13, 2017 Opened Apr 8, 2017 by cwickert.

One of the things I miss after migrating from trac to pagure are tables in issues. Even though tables are not officially part of the Markdown specification, there are several implementations. The one from Github is widely recognized, so it would be nice to support it.

pingou commented Apr 8, 2017

I believe we support this one: http://pythonhosted.org/Markdown/extensions/tables.html

First Header	Second Header
Content Cell	Content Cell
Content Cell	Content Cell

cwickert commented Apr 8, 2017

You are right, but it's not obvious due to the CSS.

Formatting within tables seems to be implemented, but orientation is not:

Left-aligned	Center-aligned	Right-aligned
git status	git status	git status
git diff	git diff	git diff

As you can see, everything is aligned right.

cwickert commented Apr 8, 2017

Oh, and there is no spaceing after tables. I inserted two blank lines, nevertheless the last sentence comes right after the table.

Metadata Update from @pingou:
- Issue tagged with: bug, easyfix

Apr 9, 2017

pingou commented Apr 9, 2017

We can easily fix/adjust the CSS, the orientation, that is likely a RFE to bring upstream though.

cwickert commented Apr 11, 2017

I think upstream already supports orientation, there is a function called _doTable_makeAlignAttr.

pingou commented Apr 11, 2017

You're pointing to a php library there :)

cwickert commented Apr 11, 2017

Sorry, I feel really bad and dirty now. ;-)

You linked http://pythonhosted.org/Markdown/extensions/tables.html, which in turn links to http://www.michelf.com/projects/php-markdown/extra/#table for reference.

Anyway, it should be in python-markdown, too.

pingou commented Apr 11, 2017

Good catch and I found the reason, we are currently trimming these element.

I'm pushing the fix, thanks for investigating this!

pingou commented Apr 11, 2017

How does this looks to you?