pagure

#2242 Too many redis clients sometimes
Closed: Fixed Opened by puiterwijk.

Closed: Fixed
Reopen Issue

I just saw this on production, blocking any and all changes:

[Wed Apr 19 21:40:03.834989 2017] [:error] [pid 28533] Traceback (most recent call last):
[Wed Apr 19 21:40:03.834991 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/flask/app.py", line 1817, in wsgi_app
[Wed Apr 19 21:40:03.834993 2017] [:error] [pid 28533]     response = self.full_dispatch_request()
[Wed Apr 19 21:40:03.834995 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/flask/app.py", line 1477, in full_dispatch_request
[Wed Apr 19 21:40:03.834998 2017] [:error] [pid 28533]     rv = self.handle_user_exception(e)
[Wed Apr 19 21:40:03.835000 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/flask/app.py", line 1381, in handle_user_exception
[Wed Apr 19 21:40:03.835002 2017] [:error] [pid 28533]     reraise(exc_type, exc_value, tb)
[Wed Apr 19 21:40:03.835004 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
[Wed Apr 19 21:40:03.835007 2017] [:error] [pid 28533]     rv = self.dispatch_request()
[Wed Apr 19 21:40:03.835009 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
[Wed Apr 19 21:40:03.835011 2017] [:error] [pid 28533]     return self.view_functions[rule.endpoint](**req.view_args)
[Wed Apr 19 21:40:03.835013 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/pagure/__init__.py", line 409, in decorated_function
[Wed Apr 19 21:40:03.835015 2017] [:error] [pid 28533]     return function(*args, **kwargs)
[Wed Apr 19 21:40:03.835017 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/pagure/ui/fork.py", line 720, in pull_request_edit_comment
[Wed Apr 19 21:40:03.835020 2017] [:error] [pid 28533]     folder=APP.config['REQUESTS_FOLDER'],
[Wed Apr 19 21:40:03.835022 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/pagure/lib/__init__.py", line 1195, in edit_comment
[Wed Apr 19 21:40:03.835024 2017] [:error] [pid 28533]     redis=REDIS,
[Wed Apr 19 21:40:03.835026 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/pagure/lib/notify.py", line 66, in log
[Wed Apr 19 21:40:03.835028 2017] [:error] [pid 28533]     'msg': msg,
[Wed Apr 19 21:40:03.835030 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/redis/client.py", line 1888, in publish
[Wed Apr 19 21:40:03.835038 2017] [:error] [pid 28533]     return self.execute_command('PUBLISH', channel, message)
[Wed Apr 19 21:40:03.835046 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/redis/client.py", line 571, in execute_command
[Wed Apr 19 21:40:03.835057 2017] [:error] [pid 28533]     return self.parse_response(connection, command_name, **options)
[Wed Apr 19 21:40:03.835061 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/redis/client.py", line 577, in parse_response
[Wed Apr 19 21:40:03.835063 2017] [:error] [pid 28533]     response = connection.read_response()
[Wed Apr 19 21:40:03.835065 2017] [:error] [pid 28533]   File "/usr/lib/python2.7/site-packages/redis/connection.py", line 574, in read_response
[Wed Apr 19 21:40:03.835068 2017] [:error] [pid 28533]     raise response
[Wed Apr 19 21:40:03.835070 2017] [:error] [pid 28533] ResponseError: max number of clients reached

Restarted pagure_ev which temporarily solves the problem:

# redis-cli  client list |wc -l
122

Note: I get an email about this everytime some action fail because of this

Is this fixed?

We haven't seen this in a while now, so I'm going to close it.

Thanks for fixing it @puiterwijk !

Metadata Update from @pingou:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)
Metadata
None
None
None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.