pagure

#2350 Same PR getting merged twice
Closed: Fixed Opened by mohanboddu.

Closed: Fixed
Reopen Issue

Sometimes when two people merge same PR at about same time, it merges it twice. AFAIK nothing bad is happening with it but the history shows that two people merged it one after the other. Also, its a deletion thats why I think nothing horrible happened, but if a PR has both deletion and addition then I am not sure how it is going to respond.

Ex: https://pagure.io/fedora-kickstarts/pull-request/241#

On the backend we are using a message queue and locking so requests are only performed one at a time per repo. So two people clicking on the same button at the same time should have no impact on the git repo (but does have one in the UI as you pointed out).

I am not sure how we could prevent race-condition, may be something to look into but not a very high priority.

Metadata Update from @pingou:
- Issue tagged with: bug

I'm pretty sure we've added the checks to ensure this no longer happen.

Let's re-open if it does but it should be fixed :)

Metadata Update from @pingou:
- Issue close_status updated to: Fixed
Metadata
None

bug

None
None
None
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.