#2462 Activate "Block Un-Signed commits" hook crashes
Closed: Fixed Opened by pingou.

traceback:

2017-07-28 10:03:19,550 [ERROR] pagure: Exception on /rpms/xmvn/settings/Block Un-Signed commits [POST]
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/flask/app.py", line 1817, in wsgi_app
    response = self.full_dispatch_request()
  File "/usr/lib/python2.7/site-packages/flask/app.py", line 1477, in full_dispatch_request
    rv = self.handle_user_exception(e)
  File "/usr/lib/python2.7/site-packages/flask/app.py", line 1381, in handle_user_exception
    reraise(exc_type, exc_value, tb)
  File "/usr/lib/python2.7/site-packages/flask/app.py", line 1475, in full_dispatch_request
    rv = self.dispatch_request()
  File "/usr/lib/python2.7/site-packages/flask/app.py", line 1461, in dispatch_request
    return self.view_functions[rule.endpoint](**req.view_args)
  File "/usr/lib/python2.7/site-packages/pagure/__init__.py", line 431, in decorated_function
    return function(*args, **kwargs)
  File "/usr/lib/python2.7/site-packages/pagure/ui/plugins.py", line 139, in view_plugin
    plugin.set_up(repo)
  File "/usr/lib/python2.7/site-packages/pagure/hooks/__init__.py", line 57, in set_up
    os.path.join(folder, project.path)
  File "/usr/lib64/python2.7/posixpath.py", line 77, in join
    elif path == '' or path.endswith('/'):
AttributeError: 'NoneType' object has no attribute 'endswith'

Metadata Update from @pingou:
- Issue tagged with: bug, pkgs.fp

Happens with any other hook I tried too.

Can you tell me how to replicate this ?

  • I tried running my local instance
  • Created a project
  • Settings --> Activate hook

Works fine didn't got any traceback, although I see a 302 on the console.

Metadata Update from @pingou:
- Issue assigned to pingou

Commit 8c7787f9 relates to this ticket

Commit 4fe245b6 fixes this issue

Metadata