pagure

#2707 Git blame output is broken
Closed: Fixed Opened by vondruch.

Closed: Fixed
Reopen Issue

The hashes are of by one, not mentioned that some lines contains names where the other displays just avatars. Please see the attached SS of Pagure vs the "git blame" output

Snimek_z_2017-10-25_18-19-14.png

Snimek_z_2017-10-25_18-19-43.png

Actually, there seems to be missing the first and last line (both empty lines), like if some "trim" was applied on the file.

By default pagure will only show the avatar, but when it cannot find an user associated with the email of the committer, it uses the name set in the commit. So in this case, pagure doesn't know Rex's email address and thus display his name.

I'll look at the line issue, it is a little odd indeed.

Metadata Update from @pingou:
- Issue tagged with: bug

I tracked this down to pygments.highlight() being the culprit at removing the leading and trailing empty lines, but I don't have a fix for it :(

Metadata Update from @pingou:
- Issue assigned to karsten

Metadata Update from @pingou:
- Issue assigned to pingou (was: karsten)

Commit 5d875801 fixes this issue
Metadata

bug

None
None
None
Related Pull Requests
Static archive. pagure.io was sunset in 2026; this is a read-only snapshot.
Red Hat Logo

Fedora is sponsored by Red Hat. Learn more about the relationship between Red Hat and Fedora »

© Red Hat, Inc. and others.